Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mlpack] Add feature openmp #18942

Merged
merged 5 commits into from
Jul 16, 2021
Merged

Conversation

JackBoosY
Copy link
Contributor

Fixes #18423.

@JackBoosY JackBoosY added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:internal This PR or Issue was filed by the vcpkg team. labels Jul 14, 2021
@JackBoosY
Copy link
Contributor Author

@DanL1234 Can you please test openmp feature with my changes?

Thanks.

@DanL1234
Copy link

Hi @JackBoosY - absolutely, would love to help. Can you tell me what I need to do? (I guess I need to try a fix you have made in a branch?) Sorry, but you will need to give me baby-steps as I am not familiar with git (I worked in tortoise SVN many years ago, so get the underlying idea, if not the procedure).

Ps. Thank you for your help on this issue - very much appreciated. :-)

@JackBoosY
Copy link
Contributor Author

@DanL1234 You can click the command line instructions link in this page.

versions/m-/mlpack.json Outdated Show resolved Hide resolved
@NancyLi1013 NancyLi1013 added the info:reviewed Pull Request changes follow basic guidelines label Jul 16, 2021
@DanL1234
Copy link

@DanL1234 Can you please test openmp feature with my changes?

Thanks.

@JackBoosY - hi there. I just got around to trying this and had an issue.

Steps I took:

  1. git clone https://github.com/JackBoosY/vcpkg.git
  2. git checkout dev/jack/18423
  3. rename c:\src\vcpkg\ to c:\src\vcpkg-18423\
  4. entered the directory \vcpkg-18423\
  5. called .\bootstrap-vcpkg.bat
  6. .\vcpkg install mlpack:x64-windows

All dependencies are built fine according to powershell output, until it gets to "mlpack", package 80 of 80.

Issue seen:

See attached screen capture and log that is being referred to. (plus an extra one for fun ;-))

1png
install-x64-windows-rel-out.log
install-x64-windows-dbg-out.log

Did I do something wrong do you think?

Thanks in advance.
Daniel

@vicroms
Copy link
Member

vicroms commented Jul 16, 2021

@DanL1234

From your logs I can see that you're running out of memory when compiling mlpack. Also in order to test that the feature works it should be vcpkg install mlpack[openmp].

fatal error C1060: compiler is out of heap space

@vicroms
Copy link
Member

vicroms commented Jul 16, 2021

@JackBoosY

Successfully tested new feature locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How do I set the compiler to use for a package and all its dependencies?
5 participants